[FIR-318] Pin the flydocs input focus ring to the product's translucent halo - #61
Merged
Merged
Conversation
Avoids colliding with dev servers commonly left running on 4300.
…nslucent halo ff-input already reads --ff-input-focus-ring for its wrapper box-shadow with a solid-color fallback; the flydocs theme previously left it unset, so focus fell back to a hard-edged outline instead of the product's translucent ring. Pin it to the product's own rgba value in light and dark, and record the resolved parity delta.
… halo Only the focused specimen's darwin baseline changes pixels; every other input state and wave-5 baseline is unaffected. Drops the stale linux baseline so CI reseeds it against the new rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves the ff-input focus-ring parity delta flagged by the FF-CAT-20 gate (FIR-318, from FIR-294's parity report): the flydocs theme pins
--ff-input-focus-ring— the component tokenff-inputalready consumes as its focus box-shadow (zero package changes) — to the product's real translucent halo:rgba(59, 89, 245, 0.25)(verbatim--hub-sys-focus-ring-color,_theme-flydocs.scss)rgba(99, 120, 255, 0.3)(the product's own dark re-pin,_theme-dark.scss)Accessibility: the wrapper's solid focus border-color remains the primary, fully-opaque indicator; the halo is additive — no WCAG regression.
Also included (approved batch-gate change): playground e2e port moved 4300 → 4310 so the VR suite stops colliding with local dev servers (
reuseExistingServer+ occupied 4300 previously risked screenshotting the wrong app).Docs updated (token equivalence rewritten for the halo; parity report flips ff-input⚠️ → ✅). Focused-state darwin baseline regenerated; its linux twin deleted (reseed via
seed_vr_baselinesafter this lands on the branch).How to verify
pnpm nx e2e playground-e2e— 15/15 on port 4310.pnpm nx serve playground --port 4310→ /parity, flydocs theme, Tab into the Search input: soft halo over the solid border (dark mode: lifted blue halo).Traceability
Board ticket without owning PASO: key in branch and commit subjects.